-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-17] Add GEP-17 with an updated Control Plane Migration "Bad Case" Scenario description #4107
Conversation
@stoyanr Label priority/normal does not exist. |
/cc @plkokanov @kris94 |
We consider this PR as ready for review now. |
/cc @amshuman-kr @vlerenc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well written, thanks for the summary and the PoC, quite interesting! Happy to attend the meeting the next!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the write-up. I had a few questions, please see inline.
@stoyanr Label priority/normal does not exist. |
/cc @plkokanov @kris94 @rfranzke @timebertt @vlerenc @amshuman-kr @mandelsoft @MartinWeindel To make the bad case scenario description easier to understand and discuss, I moved it to a new GEP (GEP-17). It was independent from the old GEP (GEP-7) already which is already implemented and released. The new proposal is very different from the original one proposed about 3 months ago. It is significantly simpler, as it is based on the owner DNS records that could be meanwhile introduced after the DNSRecords feature was implemented. There are no more I resolved all existing comments, since they were either no longer relevant (regarding parts that have been removed), or sufficiently well answered (at least from my perspective). As before, everything you see in the proposal has been implemented and tested as part of the PoC, and the productization of certain parts (copying of snapshots) is already ongoing. |
/touch |
Thank you @stoyanr and colleagues. The new proposal can be understood very well and seems safer and also easier to build. A question that I would have is what happens if the destination seed cannot access the source seed's backup bucket. Should that happen, the migration needs to be put on hold (possibly indefinitely) as without a backup/snapshot there is no point in bringing back the cluster as it would be empty. How will this be guardrailed? |
Yes, this is what will happen. The copying of snapshots task will fail, and the restoration flow will keep retrying it until it eventually succeeds, or until the shoot is marked as |
@rfranzke Thanks for your feedback! I added a new section to the GEP regarding Handling Inability to Resolve the Owner DNS Record and I answered all your other comments. I think no other changes to the GEP are required, let me know if you still miss something. |
c567bdc
to
6b55fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…" Scenario description (gardener#4107) * Remove old base case description * Update GEP-7 with a new bad case scenario description * Move CPM bad case description to a new GEP * Update GEP-17 with the latest PoC changes * Add Handling Inability to Resolve the Owner DNS Record section
…" Scenario description (gardener#4107) * Remove old base case description * Update GEP-7 with a new bad case scenario description * Move CPM bad case description to a new GEP * Update GEP-17 with the latest PoC changes * Add Handling Inability to Resolve the Owner DNS Record section
How to categorize this PR?
/area control-plane-migration
/area documentation
/kind enhancement
/priority normal
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #1631
Special notes for your reviewer:
This PR supercedes #3066. While it builds upon the same main ideas, the description is restructured and aligned with the results of the PoC.
Release note: